[alsa-devel] [PATCH] ALSA: snd-usb-usx2y: remove bogus frame check

Daniel Mack zonque at gmail.com
Wed Oct 2 17:49:29 CEST 2013

On 02.10.2013 17:43, Takashi Iwai wrote:
> At Wed,  2 Oct 2013 15:54:28 +0200,
> Daniel Mack wrote:
>> The frame check in i_usX2Y_urb_complete() is bogus and produces false
>> positives as described in this LAU thread:
>>   http://linuxaudio.org/mailarchive/lau/2013/5/20/200177
>> This code removes the check code entirely.
>> Cc: fzu at wemgehoertderstaat.de
>> Reported-by: Dr Nicholas J Bailey <nicholas.bailey at glasgow.ac.uk>
>> Suggested-by: Takashi Iwai <tiwai at suse.de>
>> Signed-off-by: Daniel Mack <zonque at gmail.com>
> It's referred in usx2yhwdeppcm.c, too (the file is included there).

Eek. I missed that. Thanks for the heads-up.

> Yeah, I know that the driver code is fairly complex (IOW ugly).  IIRC,
> the hwdeppcm mmap is also broken, and we need yet another fix.
> Sigh...

I don't know if Karsten (cc) is still maintaning this piece of code :-/


More information about the Alsa-devel mailing list