[alsa-devel] [PATCH] ASoC: kirkwood: Fix invalid SPDIF format

Takashi Iwai tiwai at suse.de
Tue Nov 26 11:20:48 CET 2013


At Tue, 26 Nov 2013 10:41:40 +0100,
Jean-Francois Moine wrote:
> 
> This patch removes the 32 bits format which is not supported by S/PDIF
> output.
> 
> Signed-off-by: Jean-Francois Moine <moinejf at free.fr>

Not against the patch itself, but just found looking through it:

> @@ -493,7 +497,7 @@ static struct snd_soc_dai_driver kirkwood_i2s_dai_extclk[2] = {
>  		.rates = SNDRV_PCM_RATE_8000_192000 |
>  			 SNDRV_PCM_RATE_CONTINUOUS |
>  			 SNDRV_PCM_RATE_KNOT,

Setting both CONTINUOUS and KNOT doesn't make sense.


Takashi


More information about the Alsa-devel mailing list