[alsa-devel] [PATCH 02/17] firewire-lib: Add macros instead of fixed value for AMDTP

Takashi Sakamoto o-takashi at sakamocchi.jp
Tue Nov 26 10:50:08 CET 2013


Hi Clemens,

(Nov 26 2013 00:27), Clemens Ladisch wrote:
> Takashi Sakamoto wrote:
>> This patch adds some macros instead of fixed value for AMDTP in IEC 61883-6.
>> These macros will also be used by followed patches.
>
>> +++ b/sound/firewire/amdtp.c
>
>> +/*
>> + * Audio and Music transfer protocol specific parameters
>> + * only "Clock-based rate controll mode" is supported
>                               ^^^^^^^^
>                               control

OK. It's my typo.

>> -		return 0xffff; /* no info */
>> +		return CIP_SYT_NO_INFO; /* no info */
>
> The comment is now superfluous.

Oops. I forget to remove it when I applied git-rebase to include my 
patch about empty packet...

Thank you.


Takashi Sakamoto
o-takashi at sakamocchi.jp



More information about the Alsa-devel mailing list