[alsa-devel] [PATCH 1/6] ASoC: Add resource managed snd_dmaengine_pcm_register()

Lars-Peter Clausen lars at metafoo.de
Mon Nov 25 18:42:56 CET 2013


On 11/25/2013 06:19 PM, Mark Brown wrote:
> On Sun, Nov 24, 2013 at 02:20:57PM +0100, Lars-Peter Clausen wrote:
>
>> ---
>>   include/sound/dmaengine_pcm.h         |  4 ++++
>>   sound/soc/soc-generic-dmaengine-pcm.c | 36 +++++++++++++++++++++++++++++++++++
>
> Please put the code in soc-devres.c.  Otherwise this looks good, thanks!
>

I didn't put it there because it has a dependency on 
SND_SOC_GENERIC_DMAENGINE_PCM. Sothe options were to either add ifdefery to 
soc-devres.c or to put the managed function in soc-generic-dmaengine-pcm.c.

- Lars


More information about the Alsa-devel mailing list