[alsa-devel] [PATCH] ASoC: dapm: Use SND_SOC_DAPM_INIT_REG_VAL in SND_SOC_DAPM_MUX
broonie at kernel.org
Fri Nov 22 19:32:16 CET 2013
On Fri, Nov 22, 2013 at 10:29:18AM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren at nvidia.com>
> SND_SOC_DAPM_MUX() doesn't currently initialize the .mask field. This
> results in the mux never affecting HW, since no bits are ever set or
> cleared. Fix SND_SOC_DAPM_MUX() to use SND_SOC_DAPM_INIT_REG_VAL() to
> set up the reg, shift, on_val, and off_val fields like almost all other
> SND_SOC_xxx() macros. It looks like this was a "typo" in the fixed
> commit linked below.
Hrm. Why has nobody else noticed this? I've been doing plenty of
testing that involved changing muxes... The patch and reasoning makes
sense but I can't immediately see why any of the testing I've been doing
recently would've worked without it since it all relies on muxes being
configured to make any noise.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel