[alsa-devel] [PATCHv4] ASoC: Add support for BCM2835

Mark Brown broonie at kernel.org
Fri Nov 22 15:05:19 CET 2013


On Fri, Nov 22, 2013 at 02:32:19PM +0100, Florian Meier wrote:
> > +	dev = devm_kzalloc(&pdev->dev, sizeof(*dev),
> > +			   GFP_KERNEL);
> > +	if (IS_ERR(base))
> > +		return PTR_ERR(base);

> Found a typo here, should be IS_ERR(dev) and PTR_ERR(dev).

No, it should be a check for NULL and returning -ENOMEM.

> Is the patch acceptable apart from that now?

Not looked yet.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20131122/c9136bce/attachment.sig>


More information about the Alsa-devel mailing list