[alsa-devel] [PATCH 19/20] ASoC: davinci-mcasp: Support for fck reparenting

Peter Ujfalusi peter.ujfalusi at ti.com
Thu Nov 14 13:59:19 CET 2013


On 11/14/2013 01:51 PM, Mark Brown wrote:
> On Thu, Nov 14, 2013 at 11:35:35AM +0200, Peter Ujfalusi wrote:
> 
>> +- fck_parent : Should contain a valid clock name which will be used as parent
>> +	       for the McASP fck
> 
> I'd expect this to be specified using standard clock tree bindings?

As of now we do not have (AM33xx/AM43xx/DRA7xx) clocks in DT so the standard
clock tree bindings can not be added (no phandle to link).
In arch OMAP we have another issue coming from legacy: omap-hwmod will treat
the standard clock bindings as optional clocks and when the device got enabled
it enables the main fck and also the optional clocks. This will not cause big
issue at the end, but the prepare/enable count for the parent clock will be
doubled. fck enable will enable the branch (including parent) and the
omap-hwmod code will enable the optional clocks, which includes the parent
clock :o

For now I would keep the parent clock name and when we have the standard clock
bindings ready I can switch to use to that.

-- 
Péter


More information about the Alsa-devel mailing list