[alsa-devel] [PATCH] drm/radeon/audio: fix missing multichannel PCM SAD in some cases

Rafał Miłecki zajec5 at gmail.com
Fri Nov 1 00:46:48 CET 2013

2013/11/1 Rafał Miłecki <zajec5 at gmail.com>:
> 2013/10/29 Anssi Hannula <anssi.hannula at iki.fi>:
>> Fix the code to pick the PCM SAD with the highest number of channels,
>> while merging the rate masks of PCM SADs with lower amount of channels
>> into the additional stereo rate mask byte.
> Does it mean that now instead of 2 real SADs:
> 1) 192kHz support for 2 channels
> 2) 96kHz support for 8 channels
> you will only get:
> 1) 192kHz support for 8 channels
> ?
> Does it mean alsa may try to play 8channels audio at 192kHz and fail at this?
> That doesn't sound good, but on the other hand I can't propose
> anything better :|

Ahh, wait. I just noticed you're using SUPPORTED_FREQUENCIES and
(different one) SUPPORTED_FREQUENCIES_STEREO there. Sorry I missed
that earlier.

Yeah, just code makes much more sense, I just think the logic in
setting that frequency may be a bit bad... Let me think about this
clearly tomorrow and I'll let you know :)


More information about the Alsa-devel mailing list