[alsa-devel] [PATCH 2/3] lx6464es: dump MAC in standard form
andriy.shevchenko at linux.intel.com
Wed May 29 13:31:07 CEST 2013
On Wed, 2013-05-29 at 13:03 +0200, Takashi Iwai wrote:
> > > > - sprintf(card->shortname, "LX6464ES %02X.%02X.%02X.%02X.%02X.%02X",
> > > > - chip->mac_address, chip->mac_address, chip->mac_address,
> > > > - chip->mac_address, chip->mac_address, chip->mac_address);
> > > > + sprintf(card->shortname, "LX6464ES %pM", chip->mac_address);
> > >
> > > This will change from the upper to the lower case, thus it'll lead to
> > > an incompatible name string, unfortunately.
> > Who is the user of this string?
> It's exposed to the user-space via ioctl and it can be used as an id
> string. So this will break user-space compatibility.
MAC is theoretically set of arbitrary 6 bytes.
Only what I can see here is the difference between '.' and ':' as a
delimiter. But the MAC address form is defined in IEEE 802 standards.
Anyway, I am okay if you reject this one.
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy
More information about the Alsa-devel