[alsa-devel] [PATCH 3/3] lx6464es: use %*phN to print small buffer in hex form

Andy Shevchenko andriy.shevchenko at linux.intel.com
Wed May 29 13:29:24 CEST 2013


On Wed, 2013-05-29 at 12:16 +0200, Takashi Iwai wrote: 
> >  	strcpy(card->driver, "LX6464ES");
> > -	sprintf(card->id, "LX6464ES_%02X%02X%02X",
> > -		chip->mac_address[3], chip->mac_address[4], chip->mac_address[5]);
> > +	sprintf(card->id, "LX6464ES_%3phN", chip->mac_address + 3);
> 
> The same problem as my previous comment.  The case incompatible.

Here is card->id, which might be used by userspace in defined form.
I rather agree with your objection here.

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy


More information about the Alsa-devel mailing list