[alsa-devel] [PATCH 1/4] cs42l52: use same init values for MASTERA_VOL/MASTERB_VOL.

Nicolas Schichan nschichan at freebox.fr
Thu May 23 15:17:24 CEST 2013


On 05/22/2013 08:34 PM, Mark Brown wrote:
> On Wed, May 22, 2013 at 07:19:24PM +0200, Nicolas Schichan wrote:
>>
>> Signed-off-by: Nicolas Schichan <nschichan at freebox.fr>
>
> Why?
>
>> -	{ CS42L52_MASTERB_VOL, 0x00 },	/* r21 Master B Volume */
>> +	{ CS42L52_MASTERB_VOL, 0x88 },	/* r21 Master B Volume */
>
> Note that the register defaults need to reflect the default value
> for the registers.

I was not aware of that, The solution would be then to fix MASTERB_VOL default 
value to 0x00 instead to 0x88. Shall I just send an updated version of the 
patch or the whole serie ?

Regards,

-- 
Nicolas Schichan
Freebox SAS


More information about the Alsa-devel mailing list