[alsa-devel] [PATCH 2/3] Show a warning if the alsa wrapper failed.

Takashi Iwai tiwai at suse.de
Thu May 16 10:08:56 CEST 2013


At Wed, 15 May 2013 18:58:06 +0200,
Jordi Mallach wrote:
> 
> If /proc/asound is not found, throw a warning and continue without
> any wrapping.

The purpose of aoss is to make OSS apps working *transparently*.
So spewing a warning at each time is a bad idea, IMO.

If a warning is justified, why don't you give a joyful success message
at each time if aoss can wrap the call? :)


Takashi

> 
> Signed-off-by: Jordi Mallach <jordi at debian.org>
> ---
>  alsa/aoss.in |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/alsa/aoss.in b/alsa/aoss.in
> index d8e1d6d..564eed9 100644
> --- a/alsa/aoss.in
> +++ b/alsa/aoss.in
> @@ -9,6 +9,7 @@ if [ -d /proc/asound ]; then
>    libdir=@libdir@
>    LD_PRELOAD=${libdir}/libaoss.so${LD_PRELOAD:+:$LD_PRELOAD} exec "$@"
>  else
> +  echo "Warning: /proc/asound not found. Running without ALSA wrapper."
>    exec "$@"
>  fi
>  exit 1
> -- 
> 1.7.10.4
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 


More information about the Alsa-devel mailing list