[alsa-devel] [PATCH 5/5] tegraalc5632: add UCM config from Ubuntu

[Stephen Warren]

On 05/10/2013 06:51 AM, Marcin Juszkiewicz wrote:
> Signed-off-by: Marcin Juszkiewicz <marcin at juszkiewicz.com.pl>
> ---
>  tegraalc5632/tegraalc5632.conf | 30 ++++++++++++++++++++++++++++++

I'm not sure that's the correct name for this file.

"alc5632" is the name of the audio CODEC, which could be used in a
variety of different boards, each of which might require a different UCM
configuration. Shouldn't the file be named based on the board name. At
least with upstream kernels, the device tree contains:

nvidia,model = "Compal PAZ00";

which should influence the name the kernel gives to the sound card, and
hence I think be the name the UCM config is looked up under?

> +		exec "echo Im setting defaults for tegra-alc5632"

I'm not sure if that's useful?

I also notice that this file doesn't define any use-cases/verbs/...
Presumably a Linux-based OS would expect a certain set of them to exist,
and they'd be implemented/named consistently across all UCM configs?