[alsa-devel] [PATCH 3/6] ASoC: ux500: Drop pinctrl sleep support

Mark Brown broonie at kernel.org
Wed May 8 14:32:25 CEST 2013

On Wed, May 08, 2013 at 01:42:16PM +0200, Fabio Baltieri wrote:
> On Wed, May 08, 2013 at 11:51:24AM +0100, Mark Brown wrote:

> > I tend to agree with Lee that this looks like a bad approach - there's a
> > whole bunch of other code in there which I'd guess is probably equally
> > broken but only the pinctrl code is being removed.  Why not just fix it
> > (or better yet simplify all this stuff)?

> Sorry I did not get the subject, are you referring to other broken code
> in the ux500 driver or to pinctrl and shared pins in generals?

I'm saying that if functions like enable_msp() don't work reliably then
removing some but not all of their functionality isn't an obviously good
approach to fixing that.  Why does the other functionality work well but
not this bit?  It sounds like there's some reference counting bug here
is all...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130508/304c1924/attachment.sig>

More information about the Alsa-devel mailing list