[alsa-devel] [PATCH v2 1/2] ALSA: hda - bug fix on return value when getting HDMI ELD info

mengdong.lin at intel.com mengdong.lin at intel.com
Thu Mar 28 10:20:22 CET 2013

From: Mengdong Lin <mengdong.lin at intel.com>

In function snd_hdmi_get_eld(), the variable 'ret' should be initialized to 0.
Otherwise it will be returned uninitialized as non-zero after ELD info is got
successfully. Thus hdmi_present_sense() will always assume ELD info is invalid
by mistake, and /proc file system cannot show the proper ELD info.

Signed-off-by: Mengdong Lin <mengdong.lin at intel.com>

diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
index 7dd8463..d0d7ac1 100644
--- a/sound/pci/hda/hda_eld.c
+++ b/sound/pci/hda/hda_eld.c
@@ -320,7 +320,7 @@ int snd_hdmi_get_eld(struct hda_codec *codec, hda_nid_t nid,
 		     unsigned char *buf, int *eld_size)
 	int i;
-	int ret;
+	int ret = 0;
 	int size;

More information about the Alsa-devel mailing list