[alsa-devel] [PATCH 06/14] ASoC: atmel-pcm-dma: No need to wrap snd_dmaengine_pcm_close()

[Bo Shen]

Hi Lars,

On 3/22/2013 21:12, Lars-Peter Clausen wrote:
> If a PCM driver using the dmaengine PCM helper functions doesn't need to do
> anything special in its pcm_close callback, snd_dmaengine_pcm_close can be used
> directly for as the pcm_close callback and there is no need to wrap it in a
> custom function.
>
> Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
> Cc: Bo Shen <voice.shen at atmel.com>

Tested-by: Bo Shen <voice.shen at atmel.com>
Acked-by: Bo Shen <voice.shen at atmel.com>

> Cc: Nicolas Ferre <nicolas.ferre at atmel.com>
> ---
>   sound/soc/atmel/atmel-pcm-dma.c | 9 +--------
>   1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/sound/soc/atmel/atmel-pcm-dma.c b/sound/soc/atmel/atmel-pcm-dma.c
> index 30184a4..396bf78 100644
> --- a/sound/soc/atmel/atmel-pcm-dma.c
> +++ b/sound/soc/atmel/atmel-pcm-dma.c
> @@ -199,16 +199,9 @@ static int atmel_pcm_open(struct snd_pcm_substream *substream)
>   	return 0;
>   }
>
> -static int atmel_pcm_close(struct snd_pcm_substream *substream)
> -{
> -	snd_dmaengine_pcm_close(substream);
> -
> -	return 0;
> -}
> -
>   static struct snd_pcm_ops atmel_pcm_ops = {
>   	.open		= atmel_pcm_open,
> -	.close		= atmel_pcm_close,
> +	.close		= snd_dmaengine_pcm_close,
>   	.ioctl		= snd_pcm_lib_ioctl,
>   	.hw_params	= atmel_pcm_hw_params,
>   	.prepare	= atmel_pcm_dma_prepare,
>