[alsa-devel] [PATCH 05/14] ASoC: ux500_pcm: No need to wrap snd_dmaengine_pcm_close()

[Ola Lilja]

Acked.

Regards,
Ola

On 03/22/2013 02:12 PM, Lars-Peter Clausen wrote:

> If a PCM driver using the dmaengine PCM helper functions doesn't need to do
> anything special in its pcm_close callback, snd_dmaengine_pcm_close can be used
> directly for as the pcm_close callback and there is no need to wrap it in a
> custom function.
> 
> Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
> Cc: Ola Lilja <ola.o.lilja at stericsson.com>
> ---
>  sound/soc/ux500/ux500_pcm.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/sound/soc/ux500/ux500_pcm.c b/sound/soc/ux500/ux500_pcm.c
> index 375ca6b..d000ba2 100644
> --- a/sound/soc/ux500/ux500_pcm.c
> +++ b/sound/soc/ux500/ux500_pcm.c
> @@ -160,18 +160,6 @@ static int ux500_pcm_open(struct snd_pcm_substream *substream)
>  	return 0;
>  }
>  
> -static int ux500_pcm_close(struct snd_pcm_substream *substream)
> -{
> -	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> -	struct snd_soc_dai *dai = rtd->cpu_dai;
> -
> -	dev_dbg(dai->dev, "%s: Enter\n", __func__);
> -
> -	snd_dmaengine_pcm_close(substream);
> -
> -	return 0;
> -}
> -
>  static int ux500_pcm_hw_params(struct snd_pcm_substream *substream,
>  			struct snd_pcm_hw_params *hw_params)
>  {
> @@ -246,7 +234,7 @@ static int ux500_pcm_mmap(struct snd_pcm_substream *substream,
>  
>  static struct snd_pcm_ops ux500_pcm_ops = {
>  	.open		= ux500_pcm_open,
> -	.close		= ux500_pcm_close,
> +	.close		= snd_dmaengine_pcm_close,
>  	.ioctl		= snd_pcm_lib_ioctl,
>  	.hw_params	= ux500_pcm_hw_params,
>  	.hw_free	= ux500_pcm_hw_free,