[alsa-devel] [PATCH 01/14] ASoC: ux500_pcm: Remove duplicated SNDRV_PCM_HW_PARAM_PERIODS constraint

Ola Lilja ola.o.lilja at stericsson.com
Fri Mar 22 15:35:37 CET 2013


Acked.

Regards,
Ola

On 03/22/2013 02:12 PM, Lars-Peter Clausen wrote:

> The generic dmaengine based PCM driver code takes care of setting this
> constraint, there is no need of doing it manually in the ux500 driver.
> 
> Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
> Cc: Ola Lilja <ola.o.lilja at stericsson.com>
> ---
>  sound/soc/ux500/ux500_pcm.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/sound/soc/ux500/ux500_pcm.c b/sound/soc/ux500/ux500_pcm.c
> index 846fa82..375ca6b 100644
> --- a/sound/soc/ux500/ux500_pcm.c
> +++ b/sound/soc/ux500/ux500_pcm.c
> @@ -111,15 +111,6 @@ static int ux500_pcm_open(struct snd_pcm_substream *substream)
>  		snd_soc_set_runtime_hwparams(substream,
>  					&ux500_pcm_hw_capture);
>  
> -	/* ensure that buffer size is a multiple of period size */
> -	ret = snd_pcm_hw_constraint_integer(runtime,
> -					SNDRV_PCM_HW_PARAM_PERIODS);
> -	if (ret < 0) {
> -		dev_err(dev, "%s: Error: snd_pcm_hw_constraints failed (%d)\n",
> -			__func__, ret);
> -		return ret;
> -	}
> -
>  	dev_dbg(dev, "%s: Set hw-struct for %s.\n", __func__,
>  		snd_pcm_stream_str(substream));
>  	runtime->hw = (stream_id == SNDRV_PCM_STREAM_PLAYBACK) ?




More information about the Alsa-devel mailing list