[alsa-devel] [PATCH 45/54 v2] ASoC: switch over to use snd_soc_register_component() on sh4 hac

[Stephen Warren]

On 03/21/2013 06:25 PM, Kuninori Morimoto wrote:
> 
> Hi Stephen
> 
> Thank you for checking patch
> 
>>>  static int hac_soc_platform_probe(struct platform_device *pdev)
>>>  {
>>> -	return snd_soc_register_dais(&pdev->dev, sh4_hac_dai,
>>> -			ARRAY_SIZE(sh4_hac_dai));
>>> +	return snd_soc_register_component(&pdev->dev, &sh4_hac_component,
>>> +					  sh4_hac_dai, ARRAY_SIZE(sh4_hac_dai));
>>>  }
>>
>> Again, ARRAY_SIZE(sh4_hac_dai) == 1 or 2 based on #ifdef
>> CONFIG_CPU_SUBTYPE_SH7760, so the names might change due to falling back
>> to snd_soc_register_dai() instead of snd_soc_register_dais().
> 
> The user of this driver was only sh7760-ac97.c in upstream kernel,
> and it have CONFIG_CPU_SUBTYPE_SH7760 (ARRAY_SIZE() == 2).
> So, it always use dais()

Oh yes, the Kconfig that enables this driver depends on
CPU_SUBTYPE_SH7760. I wonder why the ifdef is there.