[alsa-devel] [PATCH] sound: soc: fix invalid free of devm_ allocated data

Mark Brown broonie at opensource.wolfsonmicro.com
Wed Mar 20 11:05:30 CET 2013


On Sat, Mar 16, 2013 at 01:45:34PM +0200, Silviu-Mihai Popescu wrote:
> The objects allocated by devm_* APIs are managed by devres and are freed when
> the device is detached. Hence there is no need to use kfree() explicitly.

In this case since we're in error handling paths which might not be
fatal (though I suspect they probably should be normally) it looks like
the better fix is to use devm_kfree() to free immediately.  Otherwise
the unused memory will end up hanging around for as long as the device
is bound.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130320/a3da3e52/attachment.sig>


More information about the Alsa-devel mailing list