[alsa-devel] [patch] ALSA: ASoC: tas5086: signedness bug in tas5086_hw_params()

Dan Carpenter dan.carpenter at oracle.com
Wed Mar 13 06:32:53 CET 2013

"val" has to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/sound/soc/codecs/tas5086.c b/sound/soc/codecs/tas5086.c
index 008bea4..41d03ae 100644
--- a/sound/soc/codecs/tas5086.c
+++ b/sound/soc/codecs/tas5086.c
@@ -251,7 +251,7 @@ static int tas5086_hw_params(struct snd_pcm_substream *substream,
 	struct snd_soc_codec *codec = dai->codec;
 	struct tas5086_private *priv = snd_soc_codec_get_drvdata(codec);
-	unsigned int val;
+	int val;
 	int ret;
 	priv->rate = params_rate(params);

More information about the Alsa-devel mailing list