[alsa-devel] [PATCH] hda-emu: stream tag should always be non-zero

Takashi Iwai tiwai at suse.de
Tue Mar 12 17:20:15 CET 2013


At Tue, 12 Mar 2013 17:06:06 +0100,
David Henningsson wrote:
> 
> Sending zero as stream tag is discouraged, because it means no
> data, and the real code doesn't do that. Avoid it here too.
> 
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>

Thanks, applied.


Takashi

> ---
>  hda-emu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hda-emu.c b/hda-emu.c
> index c98a3ea..13756bb 100644
> --- a/hda-emu.c
> +++ b/hda-emu.c
> @@ -760,7 +760,7 @@ void hda_test_pcm(int id, int op, int subid,
>  		}
>  		hda_log(HDA_LOG_INFO, "PCM format_val = 0x%x\n", format_val);
>  #ifdef HAVE_COMMON_PREPARE
> -		err = snd_hda_codec_prepare(_codec, hinfo, subid,
> +		err = snd_hda_codec_prepare(_codec, hinfo, subid + 1,
>  					    format_val, substream);
>  #else
>  		err = hinfo->ops.prepare(hinfo, _codec, 1, format_val, substream);
> -- 
> 1.7.9.5
> 


More information about the Alsa-devel mailing list