[alsa-devel] [RFC][PATCH] ASoC: remove codec from list if registration failed

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Fri Mar 8 02:42:33 CET 2013


Current snd_soc_register_codec() adds codec to list, and calls
snd_soc_register_dais().
But, this listed codec should be removed if dais registration
was failed.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
---

If my understanding is correct...

 sound/soc/soc-core.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 1ac96df..38d6182 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -4097,6 +4097,10 @@ int snd_soc_register_codec(struct device *dev,
 	return 0;
 
 fail_codec_name:
+	mutex_lock(&client_mutex);
+	list_del(&codec->list);
+	mutex_unlock(&client_mutex);
+
 	kfree(codec->name);
 fail_codec:
 	kfree(codec);
-- 
1.7.9.5



More information about the Alsa-devel mailing list