[alsa-devel] [PATCH v2] davinci-mcasp: Add support for multichannel playback

[Michal Bachraty]

Hi Vaibhav,
 
> > >>  	return 0;
> > >> 
> > >> @@ -936,13 +978,13 @@ static struct snd_soc_dai_driver
> > >> davinci_mcasp_dai[] = {> >> 
> > >>  		.name		= "davinci-mcasp.0",
> > >>  		.playback	= {
> > >>  		
> > >>  			.channels_min	= 2,
> > >> 
> > >> -			.channels_max 	= 2,
> > >> +			.channels_max	= 8,
> > > 
> > > Why are you setting this to 8?
> > 
> > Well, the ASoC core will look at this field when parsing the dai links,
> > and will build a sound card that has min(codec_dai->channels_max,
> > cpu_dai->channels_max) channels. Hence, this number has to reflect the
> > maximum possible output channels for this DAI. In v3, it's actually set
> > to 512. Or was that not your question?
> 
> 32 slots on a max of 16 serializers gives the max as 512 and hence I wanted
> to know why 8 was selected.

That number was changed in patch v3 to 512.  8 was selected only for Am335 and 
2TDM slots. That number was not general and therefore it was changed.  It is 
no need for discusion for that number, because it was changed to proper value 
in v3 of this patch. If not, let us know.

Michal.