[alsa-devel] [PATCH v4 2/2] ALSA: ASoC: davinci-mcasp: don't overwrite DIT settings

Yegor Yefremov yegorslists at googlemail.com
Mon Mar 4 12:09:44 CET 2013

On Mon, Mar 4, 2013 at 12:02 PM, Daniel Mack <zonque at gmail.com> wrote:
> On 04.03.2013 11:58, Yegor Yefremov wrote:
>> On Mon, Mar 4, 2013 at 11:43 AM, Daniel Mack <zonque at gmail.com> wrote:
>>> On 04.03.2013 11:34, yegorslists at googlemail.com wrote:
>>>> From: Yegor Yefremov <yegorslists at googlemail.com>
>>>> Channel size settings will be made at the end of
>>>> davinci_mcasp_hw_params() routine and thus overwrite frame
>>>> format settings made for DIT mode. This patch fixes this issue
>>>> by taking op_mode into account. Tested with official PSP 3.2
>>>> kernel and sii9022a HDMI transmitter.
>>>> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
>>> For both, wrt a survived regression test :)
>>> Tested-by: Daniel Mack <zonque at gmail.com>
>> Thanks.
>> How do you make the test? Is it "doesn't break compilation" test? Or
>> do you have S/PDIF capable device?
> No, I'm running the driver in IIS mode, with a codec attached to the I2S
> lines. All I can do for now is test that your patches do not break my
> environment. I can not test DIT.

O.K. I see. That is actually, what I wonted to know, if it doesn't break i2s.


More information about the Alsa-devel mailing list