[alsa-devel] [PATCH] ASoC: ep93xx: Remove redundant dev_set_drvdata() calls

Mark Brown broonie at kernel.org
Wed Jun 26 13:02:47 CEST 2013


From: Mark Brown <broonie at linaro.org>

The driver core does this and it's never legal to rely on the value of
drvdata if not set in probe() anyway.

Signed-off-by: Mark Brown <broonie at linaro.org>
---
 sound/soc/cirrus/ep93xx-ac97.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sound/soc/cirrus/ep93xx-ac97.c b/sound/soc/cirrus/ep93xx-ac97.c
index 3f4f888..f193701 100644
--- a/sound/soc/cirrus/ep93xx-ac97.c
+++ b/sound/soc/cirrus/ep93xx-ac97.c
@@ -398,7 +398,6 @@ static int ep93xx_ac97_probe(struct platform_device *pdev)
 
 fail:
 	ep93xx_ac97_info = NULL;
-	dev_set_drvdata(&pdev->dev, NULL);
 	return ret;
 }
 
@@ -412,7 +411,6 @@ static int ep93xx_ac97_remove(struct platform_device *pdev)
 	ep93xx_ac97_write_reg(info, AC97GCR, 0);
 
 	ep93xx_ac97_info = NULL;
-	dev_set_drvdata(&pdev->dev, NULL);
 
 	return 0;
 }
-- 
1.8.3.1



More information about the Alsa-devel mailing list