[alsa-devel] [PATCH 0/4] ALSA: usb: misc consistency fixes

Antonio Ospite ao2 at amarulasolutions.com
Fri Jun 21 13:11:47 CEST 2013


when working on the hiFace driver (which I plan on re-sending later
today BTW) I've been reading the code of other drivers and I've stumbled
on a couple of minor inconsistencies which were also spotted during the
review rounds for the hiFace driver.

I am sending some patches to address these issues, so that new drivers
authors won't do the same mistakes I did when copying code over.

Please take a closer look at the ones about vmalloc buffers, do we need
an actual Tested-by for these?

Patches are against 3.10-rc6.


Antonio Ospite (4):
  ALSA: snd-usb-caiaq: remove the unused snd_card_used variable
  ALSA: snd-usb-caiaq: use vmalloc buffers
  ALSA: snd-usb-6fire: use vmalloc buffers
  ALSA: usb: uniform style used in MODULE_SUPPORTED_DEVICE()

 sound/usb/6fire/chip.c     |  2 +-
 sound/usb/6fire/pcm.c      | 12 +++++-------
 sound/usb/caiaq/audio.c    | 12 +++++-------
 sound/usb/caiaq/device.c   | 31 +++++++++++++++----------------
 sound/usb/usx2y/usbusx2y.c |  2 +-
 5 files changed, 27 insertions(+), 32 deletions(-)

Antonio Ospite

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

More information about the Alsa-devel mailing list