[alsa-devel] [RFC PATCH 01/11] dma: amba-pl08x: Use bitmap to pass variant specific quirks

Arnd Bergmann arnd at arndb.de
Tue Jun 18 15:33:46 CEST 2013

On Tuesday 18 June 2013, Linus Walleij wrote:
> I thought about it yesterday and it basically looks to me that
> it tries to outsmart the compiler on how to stuff the flags to save
> struct space on the heap and hint that they can be determined
> quickly by a & operation, this is like premature optimization.
> So please go back to the old system.

Note that a 'bool' is typically stored as a 32-bit field, so there
would be some space saving if there are a lot of flags.

I agree with the conclusion though, the previous state was more
readable, which outweighs any benefits.


More information about the Alsa-devel mailing list