[alsa-devel] [PATCH] ASoc: si476x: Do not use binary constants

James Hogan james.hogan at imgtec.com
Fri Jun 14 10:49:34 CEST 2013


Gcc < 4.3 doesn't understand binary constants (0b*):

sound/soc/codecs/si476x.c:172:8: error: invalid suffix "b1111110" on integer constant
sound/soc/codecs/si476x.c:219:9: error: invalid suffix "b111" on integer constant
sound/soc/codecs/si476x.c:219:56: error: invalid suffix "b111" on integer constant

So use hexadecimal constants (0x*) instead.

Signed-off-by: James Hogan <james.hogan at imgtec.com>
Cc: Andrey Smirnov <andrey.smirnov at convergeddevices.net>
Cc: Mark Brown <broonie at opensource.wolfsonmicro.com>
Cc: Liam Girdwood <lgirdwood at gmail.com>
Cc: Jaroslav Kysela <perex at perex.cz>
Cc: Takashi Iwai <tiwai at suse.de>
Cc: alsa-devel at alsa-project.org
---
 sound/soc/codecs/si476x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/si476x.c b/sound/soc/codecs/si476x.c
index 721587c..73e205c 100644
--- a/sound/soc/codecs/si476x.c
+++ b/sound/soc/codecs/si476x.c
@@ -38,9 +38,9 @@ enum si476x_digital_io_output_format {
 	SI476X_DIGITAL_IO_SAMPLE_SIZE_SHIFT	= 8,
 };
 
-#define SI476X_DIGITAL_IO_OUTPUT_WIDTH_MASK	((0b111 << SI476X_DIGITAL_IO_SLOT_SIZE_SHIFT) | \
-						  (0b111 << SI476X_DIGITAL_IO_SAMPLE_SIZE_SHIFT))
-#define SI476X_DIGITAL_IO_OUTPUT_FORMAT_MASK	(0b1111110)
+#define SI476X_DIGITAL_IO_OUTPUT_WIDTH_MASK	((0x7 << SI476X_DIGITAL_IO_SLOT_SIZE_SHIFT) | \
+						  (0x7 << SI476X_DIGITAL_IO_SAMPLE_SIZE_SHIFT))
+#define SI476X_DIGITAL_IO_OUTPUT_FORMAT_MASK	(0x7e)
 
 enum si476x_daudio_formats {
 	SI476X_DAUDIO_MODE_I2S		= (0x0 << 1),
-- 
1.8.1.2




More information about the Alsa-devel mailing list