[alsa-devel] [PATCH 2/2] ASoC: rt5640: enable LDO1 before creating regmap

Stephen Warren swarren at wwwdotorg.org
Thu Jun 13 17:09:53 CEST 2013

On 06/13/2013 03:30 AM, Mark Brown wrote:
> On Wed, Jun 12, 2013 at 03:34:24PM -0600, Stephen Warren wrote:
>> From: Stephen Warren <swarren at nvidia.com>
>> Enable the LDO1_EN GPIO to the CODEC, which enables the device to
>> show up on the I2C bus, before creating the regmap object. This
>> guarantees that if devm_regmap_init_i2c() were to attempt to
>> communicate with the device, it would be able to.
> Is this an actual issue?  Unless specifically asked to the regmap
> code really shouldn't be interacting with the hardware and the
> ordering the code currently has is the standard one so if we're
> having problems then a number of other drivers ought to be fixed.

This doesn't solve a current failure. It just seems to me that one
shouldn't create the regmap object until it's actually possible to use it.

More information about the Alsa-devel mailing list