[alsa-devel] [PATCH] ASoC: WM8962: Set CLKREG_OVD if GP5_FN is not its reset value

Mark Brown broonie at kernel.org
Fri Jun 7 17:46:20 CEST 2013

On Fri, Jun 07, 2013 at 03:33:31PM +0000, Chen Guangyu-B42378 wrote:
> On Fri, Jun 07, 2013,  Mark Brown wrote:

> > You're missing a whole batch of handling of device reset here - look at
> > how we handle things on power on.

> Are you talking about the initial code in wm8962_probe()?
> But after wm8962_runtime_resume(), register Clocking2 will be reset to its
> default value without OVD-setting and won't be recovered after regcache_sync()
> due to volatile_reg.

The point is that there's more work needed to recover the device state
here, you're only doing one of the several things that need to be done
after the device has been restored.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130607/d09bdc97/attachment-0001.sig>

More information about the Alsa-devel mailing list