[alsa-devel] [PATCH V2] ASoC: fsl: add imx-wm8962 machine driver

Mark Brown broonie at kernel.org
Thu Jun 6 15:33:42 CEST 2013

On Thu, Jun 06, 2013 at 08:49:53PM +0800, Nicolin Chen wrote:
> On Wed, Jun 05, 2013 at 12:55:44PM +0100, Mark Brown wrote:

> > Since it's easy to define a fixed rate clock (there's a generic driver
> > for that) I'd just require the user to provide a clock API clock and fix
> > the rate using that.  This is going to be less error prone and makes the
> > code simpler.

> I tried to use fixed rate clock as below:

> 	data->codec_clk = devm_clk_get(&codec_dev->dev, NULL);
> 	if (IS_ERR(data->codec_clk)) {
> 		of_fixed_clk_setup(codec_np);
> 		data->codec_clk = clk_get(NULL, codec_np->name);

No, this is silly.  Have the board define the clock in the DT.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130606/8e007b8d/attachment.sig>

More information about the Alsa-devel mailing list