[alsa-devel] [PATCH] ASoC: dapm: check suspend state in dapm_dai_check_power()

Stephen Warren swarren at wwwdotorg.org
Mon Jun 3 19:36:40 CEST 2013

From: Stephen Warren <swarren at nvidia.com>

Currently, when the system enters suspend with audio playing, since the
DAI widgets are active, the associated CODEC is considered active, and
hence is not transition into a low-power bias state as the system
suspends. This likely causes audio failure after resume, since the CODEC
power has quite possibly been removed during suspend, and the bias level
transitions in the CODEC driver are needed to recover from this. At the
very least, this issue likely causes warnings in the kernel log due to
the CODEC being left on over the suspend transition.

To solve this, modify dapm_dai_check_power() not to consider DAI widgets
active if the system is entering suspend.

Suggested-by: Lars-Peter Clausen <lars at metafoo.de>
Signed-off-by: Stephen Warren <swarren at nvidia.com>
 sound/soc/soc-dapm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 3507346..bad545a 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1133,7 +1133,7 @@ static int dapm_dai_check_power(struct snd_soc_dapm_widget *w)
 	DAPM_UPDATE_STAT(w, power_checks);
 	if (w->active)
-		return w->active;
+		return snd_soc_dapm_suspend_check(w);
 	return dapm_generic_check_power(w);

More information about the Alsa-devel mailing list