[alsa-devel] [PATCH 1/2] ASoC: wm8994: fix the codec state machine
broonie at kernel.org
Sat Jun 1 20:55:21 CEST 2013
On Thu, May 30, 2013 at 09:52:10PM +0530, Vinod Koul wrote:
> few places the mic_detecting is not updated correctly when state changes,
> causing jack detection to go wrong
This doesn't apply against current code.
> @@ -3696,6 +3697,7 @@ static irqreturn_t wm1811_jackdet_irq(int irq, void *data)
> /* Since we only report deltas force an update, ensures we
> * avoid bootstrapping issues with the core. */
> snd_soc_jack_report(wm8994->micdet.jack, 0, 0);
> + wm8994->mic_detecting = true;
This doesn't look right, as the comment says the report there isn't a
real report it's just a kick to the core. We only want to start looking
for a mic if something changed to make that a good idea or on init.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Alsa-devel