[alsa-devel] [PATCH] ASoC: core: No need to use strncmp()
dp at opensource.wolfsonmicro.com
Wed Jul 31 13:59:29 CEST 2013
On Wed, Jul 31, 2013 at 12:01:47PM +0100, Mark Brown wrote:
> On Wed, Jul 31, 2013 at 10:48:14AM +0100, Dimitris Papastamos wrote:
> > On Wed, Jul 31, 2013 at 10:07:26AM +0100, Mark Brown wrote:
> > > On Wed, Jul 31, 2013 at 09:44:13AM +0100, Dimitris Papastamos wrote:
> > > > Signed-off-by: Dimitris Papastamos <dp at opensource.wolfsonmicro.com>
> > > Why?
> > Hm, strncmp() suggests that we might not care about the entire string.
> > Although trivial, I thought strcmp() is clearer in this context.
> One of the reasons we use strncmp() here is to avoid going beyond the
> end of the fixed size buffer.
Right, surely though the kcontrol names are always null terminated?
In any case, looks more safe to strncmp().
More information about the Alsa-devel