[alsa-devel] [PATCH 08/10] ASoC: dapm: Add snd_soc_dapm_add_path() helper function

Lars-Peter Clausen lars at metafoo.de
Tue Jul 30 13:35:02 CEST 2013

On 07/29/2013 07:45 PM, Mark Brown wrote:
> On Mon, Jul 29, 2013 at 05:14:02PM +0200, Lars-Peter Clausen wrote:
>> snd_soc_dapm_add_path() is similar to snd_soc_dapm_add_route() except that it
>> expects the pointer to the source and sink widgets instead of their names. This
>> allows us to simplify the case where we already have a pointer to widgets. (E.g.
>> as we have in snd_soc_dapm_link_dai_widgets()). snd_soc_dapm_add_route() will be
>> updated to just look up the widget and then use snd_soc_dapm_add_path() to
>> handle everything else.
> I've applied everything up to patch 9, this is all really good stuff.
> This one would've been a bit easier to review if the refactoring were
> split out from the changes to the users (who could've continued to use
> add_route() for the time being).
> Patch 10 I want to have a bit more of a think about and probably try
> using it in something.

I do have a driver that uses the auto-disable feature. The plan is to submit
the driver soonish. I can resend patch 10 as part of the patch series that
adds the driver if necessary.

- Lars

More information about the Alsa-devel mailing list