[alsa-devel] [PATCH 4/6 v2 resend] ASoC: add Renesas R-Car SCU feature

[Mark Brown]

On Sun, Jul 21, 2013 at 09:36:35PM -0700, Kuninori Morimoto wrote:

> +#define RSND_GEN1_REG_MAP(g, s, i, oi, oa)				\
> +	do {								\
> +		(g)->reg_map[RSND_REG_##i].index  = RSND_GEN1_##s;	\
> +		(g)->reg_map[RSND_REG_##i].offset_id = oi;		\
> +		(g)->reg_map[RSND_REG_##i].offset_adr = oa;		\
> +	} while (0)
> +
> +static void rsnd_gen1_reg_map_init(struct rsnd_gen *gen)
> +{
> +	RSND_GEN1_REG_MAP(gen, SRU,	SSI_MODE0,	0x0,	0xD0);
> +	RSND_GEN1_REG_MAP(gen, SRU,	SSI_MODE1,	0x0,	0xD4);

This all really does look like regmap could be doing something useful
here.

> +static int rsnd_scu_init(struct rsnd_mod *mod,
> +			 struct rsnd_dai *rdai,
> +			 struct rsnd_dai_stream *io)
> +{
> +	struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
> +	struct device *dev = rsnd_priv_to_dev(priv);
> +
> +	dev_dbg(dev, "%s.%d init\n", rsnd_mod_name(mod), rsnd_mod_id(mod));
> +
> +	return 0;
> +}

Clearing out these empty functions would be good if there's any left
after the full series is applied.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130728/567858da/attachment-0001.sig>