[alsa-devel] [PATCH 1/4] ALSA: Added jack detection kcontrol support
eu at felipetonello.com
Fri Jul 26 21:04:17 CEST 2013
On Fri, Jul 26, 2013 at 11:46 AM, Mark Brown <broonie at kernel.org> wrote:
> On Fri, Jul 26, 2013 at 11:25:30AM -0700, Felipe F. Tonello wrote:
>> - snprintf(kctl->id.name, sizeof(kctl->id.name), "%s Jack", name);
>> + strlcpy(kctl->id.name, name, sizeof(kctl->id.name));
> This looks like it'd break existing users unless they are updated to
> remove the "Jack" from their calls?
Yes, that's why I appended the " Jack" in snd_jack_new().
>> * @type: a bitmask of enum snd_jack_type values that can be detected by
>> * this jack
>> + * @idx: index of this control item
>> * @jjack: Used to provide the allocated jack object to the caller.
> "The index of the ALSA control created to represent the jack.
More information about the Alsa-devel