[alsa-devel] [PATCH 4/4] ALSA: oxygen: Updating jack implementation according new ALSA Jacks

Mark Brown broonie at kernel.org
Fri Jul 26 20:56:09 CEST 2013


On Fri, Jul 26, 2013 at 11:25:33AM -0700, Felipe F. Tonello wrote:
> From: "Felipe F. Tonello" <eu at felipetonello.com>
> 
> ALSA standard jacks already are implemented using ALSA KControl.
> So there is no need implement that itself or to use snd_jack
> for input events only.

Similar changlog comment as on the ASoC patch and...

>  	snd_jack_new(chip->card, "Headphone",
> -		     SND_JACK_HEADPHONE, &data->hp_jack);
> +	             SND_JACK_HEADPHONE, 0, &data->hp_jack);
>  	xonar_ds_handle_hp_jack(chip);

...this really ought to be done as part of the commit that adds the
parameter since it breaks the build until this patch is applied.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130726/4b8979bf/attachment.sig>


More information about the Alsa-devel mailing list