[alsa-devel] [patch] ASoC: adau1701: type bug with ADAU1707_CLKDIV_UNSET
zonque at gmail.com
Fri Jul 26 17:54:02 CEST 2013
On 25.07.2013 18:40, Dan Carpenter wrote:
> ADAU1707_CLKDIV_UNSET is always compared against an unsigned int and
> not an unsigned long. The current tests are always false.
Well, in my case, sizeof(unsigned int) equals sizeof(unsigned long), so
it didn't hit me. But it should be fixed of course, thanks for catching.
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
Acked-by: Daniel Mack <zonque at gmail.com>
> diff --git a/sound/soc/codecs/adau1701.c b/sound/soc/codecs/adau1701.c
> index 44d8a95..2c10252 100644
> --- a/sound/soc/codecs/adau1701.c
> +++ b/sound/soc/codecs/adau1701.c
> @@ -91,7 +91,7 @@
> #define ADAU1701_OSCIPOW_OPD 0x04
> #define ADAU1701_DACSET_DACINIT 1
> -#define ADAU1707_CLKDIV_UNSET (-1UL)
> +#define ADAU1707_CLKDIV_UNSET (-1U)
> #define ADAU1701_FIRMWARE "adau1701.bin"
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
More information about the Alsa-devel