[alsa-devel] [PATCH 2/4] ASoc: kirkwood: simplify probe error

Mark Brown broonie at kernel.org
Thu Jul 25 21:10:59 CEST 2013


On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote:
> The function kirkwood_i2s_dev_remove() may be used when probe fails.

This seems fine but doesn't apply against current code but otherwise
seems fine.

> +	if (!IS_ERR(priv->extclk)) {
> +		clk_disable_unprepare(priv->extclk);
> +		clk_put(priv->extclk);
> +	}

Could use devm_clk_get() for extclk.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130725/12faeac0/attachment.sig>


More information about the Alsa-devel mailing list