[alsa-devel] [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Jul 23 10:53:46 CEST 2013

On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote:
> The kirkwood i2s driver is used without DT in the Kirkwood machine.
> This patch adds a DT compatible definition for use in other Marvell
> machines as the Armada 88AP510 (Dove).

Yet again, this illustrates why converting to DT causes backwards
steps in drivers: the conversion of devm_clk_get() to of_clk_get()
necessitates a clk_put().

Can someone please provide a devm_of_clk_get() function before we
accept any more patches doing this kind of thing?

The other issue is that kirkwood-dma.c and kirkwood-i2s.c should be
one driver; they're not separate hardware on these platforms, so that
needs fixing before coming up with any kind of DT model for this stuff.

More information about the Alsa-devel mailing list