[alsa-devel] [PATCH RFC 09/10] ALSA: usb-audio: clarify implicit fb quirk for Roland

[Eldad Zack]

On Sat, 20 Jul 2013, Clemens Ladisch wrote:

> Eldad Zack wrote:
> > Move the vendor ID check to the outside and also propogate
> > the error code.
> 
> > -	if (...
> > -         search_roland_implicit_fb(subs->dev, altsd->bInterfaceNumber + 1,
> > -				      altsd->bAlternateSetting,
> > -				      &alts, &ep) >= 0) {
> > -		goto add_sync_ep;
> 
> > +			int err = search_roland_implicit_fb(subs->dev, altsd->bInterfaceNumber + 1,
> > +							altsd->bAlternateSetting,
> > +						        &alts, &ep);
> > +			if (err < 0)
> > +				return err;
> > +
> > +			goto add_sync_ep;
> 
> The error code change is not a refactoring, but a logic change.
> 
> In this case, a nonexistent feedback endpoint should not be considered a fatal error.

Right, thanks!
I'll change it to return 0.

Cheers,
Eldad