[alsa-devel] [PATCH RFC 00/10] Refactor set_format()

Eldad Zack eldad at fogrefinery.com
Fri Jul 19 20:23:20 CEST 2013


This is a low-priority series (applies against current for-next).
I had the idea of refactoring set_format to make it easier to read (I
actually indended to look at the implicit feedback setup race, but
stumbled on this again).

This series is not intended to be applied as-is (it has some whitespace
issues and I wrote the commit messages quickly), but to get some
feedback - if you think it's a good idea in general, and also specific
feedback to individual patches. Assuming it makes sense, I'll fix the
whitespace issues, commit messages and anything else before resubmitting.


Eldad Zack (10):
  ALSA: usb-audio: remove disabled debug code in set_format
  ALSA: usb-audio: remove assignment from if condition
  ALSA: usb-audio: separate sync endpoint setting from set_format
  ALSA: usb-audio: move implicit fb quirks to separate function
  ALSA: usb-audio: reverse condition logic in set_sync_endpoint
  ALSA: usb-audio: do not initialize and check implicit_fb
  ALSA: usb-audio: remove is_playback from implicit feedback quirks
  ALSA: usb-audio: remove implicit_fb from quirk
  ALSA: usb-audio: clarify implicit fb quirk for Roland
  ALSA: usb-audio: check alts is not NULL before adding ep

 sound/usb/pcm.c | 249 ++++++++++++++++++++++++++++++++------------------------
 1 file changed, 144 insertions(+), 105 deletions(-)


More information about the Alsa-devel mailing list