[alsa-devel] [PATCH] ASoC: pcm: Use the power efficient workqueue for delayed powerdown

Viresh Kumar viresh.kumar at linaro.org
Thu Jul 18 12:56:53 CEST 2013


On 18 July 2013 16:24, Mark Brown <broonie at kernel.org> wrote:
> From: Mark Brown <broonie at linaro.org>
>
> There is no need to use a normal per-CPU workqueue for delayed power downs
> as they're not timing or performance critical and waking up a core for them
> would defeat some of the point.
>
> Signed-off-by: Mark Brown <broonie at linaro.org>
> ---
>  sound/soc/soc-pcm.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index b6c6403..f4f68cb 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -411,8 +411,9 @@ static int soc_pcm_close(struct snd_pcm_substream *substream)
>                 } else {
>                         /* start delayed pop wq here for playback streams */
>                         rtd->pop_wait = 1;
> -                       schedule_delayed_work(&rtd->delayed_work,
> -                               msecs_to_jiffies(rtd->pmdown_time));
> +                       queue_delayed_work(system_power_efficient_wq,
> +                                          &rtd->delayed_work,
> +                                          msecs_to_jiffies(rtd->pmdown_time));
>                 }
>         } else {
>                 /* capture streams can be powered down now */

Reviewed-by: Viresh Kumar <viresh.kumar at linaro.org>


More information about the Alsa-devel mailing list