[alsa-devel] [PATCH RFC] ALSA: usb-audio: add front jack channel selector for EMU0204

[Vasily Khoruzhick]

On Fri, Jul 12, 2013 at 3:59 PM, Takashi Iwai <tiwai at suse.de> wrote:

> > Control request looks like generic UAC_SET_CUR request, but with a bit
> weird values,
> > valid values are { 0x01, 0x01} and { 0x01, 0x02 }, and there's no such
> control type ATM.
> > I'm not well familiar with UAC so any suggestins how to get rid of
> custom control req are welcome!
>
> snd_usb_ctl_msg() call should be rewritten not to pass magic numbers
> but use constants, e.g.
>   0x01 = UAC_SET_CUR,
>   0x21 = USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_OUT
> ...
>

OK, but how to interpret wIndex and wValue values?


> And, in this case, it'd be more natural to implement as an enum
> control instead of a switch.
>

OK


>
>
> thanks,
>
> Takashi
>
>
Thanks for review!

Regards
Vasily