[alsa-devel] [PATCH v2 0/4] ASoC: Regression fix for OMAP in DT boot (3.11)

Lars-Peter Clausen lars at metafoo.de
Thu Jul 11 16:02:10 CEST 2013


On 07/11/2013 02:35 PM, Peter Ujfalusi wrote:
> Hi,
> 
> Changes since v1:
> - Drop the change in dmaengine_pcm.h
> - Use .filter_data to store the DMA channel name
>  - omap-pcm: checks if the DAI is probed via DT and uses decides which method to
>    use to request the DMA channel
> - Dropped the cleanup patch for omap-dmic from the series
>   I will send another series with cleanups later
> 
> I just noticed in mainline kernel (pre 3.11-rc1) that OMAP4 audio is not probing
> anymore. This is because OMAP4 also moved to DT only mode (3.10 DT boot was
> fine).
> The issue underneath is that we can not use platform_get_resource_byname() for
> DMA resources when booted with devicetree.
> 
> In case of DT boot we can use the DMA name to request the channel.
> 
> Due to technical issues OMAP can not be moved to generic dmaengine pcm as other
> SoCs did.
> 
> Mark: can you queue this series for 3.11? Thank you.
> 
> Regards,
> Peter

Looks good, all 4 patches:
Reviewed-by: Lars-Peter Clausen <lars at metafoo.de>

But I'm wondering who do you register the PCM device in the DT case? Do you
have a separate DT node for the PCM device?

- Lars

> ---
> Peter Ujfalusi (4):
>   ASoC: omap-pcm: Request the DMA channel differently when DT is
>     involved
>   ASoC: omap-mcpdm: Do not use platform_get_resource_byname() for DMA
>   ASoC: omap-dmic: Do not use platform_get_resource_byname() for DMA
>   ASoC: omap-mcbsp: Use different method for DMA request when booted
>     with DT
> 
>  sound/soc/omap/mcbsp.c      | 39 ++++++++++++++++++++++-----------------
>  sound/soc/omap/omap-dmic.c  | 11 +----------
>  sound/soc/omap/omap-mcpdm.c | 16 ++--------------
>  sound/soc/omap/omap-pcm.c   | 17 ++++++++++++++---
>  4 files changed, 39 insertions(+), 44 deletions(-)
> 



More information about the Alsa-devel mailing list