[alsa-devel] [PATCH 0/2] HDSPM - Documentation and TCO on AES(32)

Takashi Iwai tiwai at suse.de
Thu Jul 4 12:40:56 CEST 2013

At Tue,  2 Jul 2013 21:42:14 +0200,
Adrian Knoth wrote:
> Hi!
> Here are two patches that I've received from Martin. The first only adds
> comments to the driver to document the various register settings. Might
> be useful for other developers.
> The second patch adds TCO support on AES(32) cards. I took the liberty
> to polish Martin's work to reflect the kernel coding style. It still
> contains plenty of long-line warnings from checkpatch.pl, but I could
> live with this.
> There are also a few (five?) whitespace fixes and a typo fix which are
> technically not related to TCO support. I could manually separate them
> into two commits, but maybe it's acceptable as it is?

Yes, the current patch is too difficult to review.  I can't see what's
the real change and what's the coding style fixes.  So please split.

But, note that in general a coding style cleanup patch makes sense
only if the resultant code becomes significantly more readable.  If
it's just for shutting up checkpatch, it's a wast of time.  It might
be even worse, it makes harder to track the changes via git.

And, the coding style fixes must not change anything else than the
coding style.  It must not change the proc file texts, for example, 
as the current patch modifies the proc output "No vide" to "no
video".  Such a thing can't be changed silently. 



> Cheers
> Adrian Knoth (1):
>   ALSA: hdspm - Add TCO support for RME AES(32)
> Martin Dausel (1):
>   ALSA: hdspm - Added some comments and control register documentation
>  sound/pci/rme9652/hdspm.c | 438 +++++++++++++++++++++++++++++++++-------------
>  1 file changed, 317 insertions(+), 121 deletions(-)
> -- 

More information about the Alsa-devel mailing list