[alsa-devel] [PATCH 3/6] ASoC: add Renesas R-Car Generation feature

[Mark Brown]

On Sun, Jun 30, 2013 at 11:53:10PM -0700, Kuninori Morimoto wrote:

> +u32 rsnd_read(struct rsnd_priv *priv,
> +	      struct rsnd_mod *mod, enum rsnd_reg reg)
> +{
> +	void __iomem *base = rsnd_gen_reg_get(priv, mod, reg);
> +
> +	BUG_ON(!base);
> +
> +	return ioread32(base);
> +}

regmap?  I don't know if the new regmap field API helps with the fact
that some of the registers have been moved about.

> +static void rsnd_gen2_remove(struct platform_device *pdev,
> +			     struct rsnd_priv *priv)
> +{
> +}

There's quite a few empty functions here - it'd be better to be able to
avoid them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20130703/df49f327/attachment.sig>