[alsa-devel] [PATCH 1/2] ASoC: atmel_ssc_dai: move set dma data to startup callback

Bo Shen voice.shen at atmel.com
Wed Jul 3 03:20:25 CEST 2013

Hi Lars-Peter,

On 7/2/2013 23:25, Lars-Peter Clausen wrote:
> On 07/02/2013 11:04 AM, Bo Shen wrote:
> [...]
>> +	dma_params->substream = substream;
> Unrelated to this patch, but having a substream field in the dma_params seems
> to be redundant, since you need to know the substream to get the dma_params in
> the first place. Looking at the code it also seems to be unused other than this
> assignment. Maybe you can send a follow up patch to remove it.
> [...]

Yes, this is redundant. I will remove it in next version patches.

Best Regards,
Bo Shen

More information about the Alsa-devel mailing list